Add desktop versions? - Githubissues

etesync / etesync-notes

An EteSync backed note taking app

https://www.etesync.com

Other

87 stars 12 forks source link

Add desktop versions? #65

Open zecakeh opened 3 years ago

zecakeh commented 3 years ago

Since the app is build for the web, it should be easy to build desktop apps with Electron. It would be better than having to launch a web browser every time in my opinion 😉

I tried to follow Using Electron with Expo for Web: it builds but nothing loads in the window that is launched.

I get this error in the DevTools Console: Invalid hook call for the Provider component so I guess it's a general configuration problem.

I'm not experienced with React Native Web nor Electron but I'll try to look into it. If anyone else has some experience please step in.

tasn commented 3 years ago

That would be amazing, thanks a lot!

Salt-Factory commented 3 years ago

I've been using the notes application via Electron since it came out. I used nativefier to automatically create an Electron version. It works extremely well! There's also no local caching, so whenever the web app is updated, so is my desktop version. The only downside is that it requires a working internet connection.

Hit me up in the matrix chat if you have more questions, or if you want a copy of the Electron app.

zecakeh commented 3 years ago

I'm adding full Progressive Web App support in #109. That makes the app installable on desktop with Chrome variants (tested on Linux with Chromium and Brave).

I wonder if it also makes the app load completely offline in Nativefier…

You can test it here while it's not released: https://cranky-hodgkin-f8e6c5.netlify.app/

tasn commented 3 years ago

Deploying now (should be up in a minute)

Salt-Factory commented 3 years ago

I tested a nativefied version, and it is indeed possible to start the app offline!

zecakeh commented 3 years ago

I managed to build locally a working version with Electron. The app launches but there are a few quirks to solve:

The app opens by default on the 404 (NotFound) screen. It's only possible to login if we had a new entry to the Drawer to navigate to the Login screen, but that's not a good UX. Also, after login, we go back to 404 and have to manually navigate to the Home screen. My guess is that the navigation doesn't fallback to Login if Home is not available, and vice-versa.
The external links open in the app by default and it's impossible to go back to the app. This is also a welcome fix for the web app actually.
@expo/net-info throws errors regularly in the console, although that doesn't seem to prevent it from working. Still, that shouldn't happen.

I'll work on this some more when #106 is ready.

tasn commented 3 years ago

Great news! I'm sure we can figure out the quirks and kinks later on! Why not work on it before #106 btw? I think this can be an easier and faster win!