etesync / etesync-web

An EteSync web client
https://www.etesync.com
GNU Affero General Public License v3.0
247 stars 31 forks source link

404 Page #142

Closed ramzan closed 4 years ago

ramzan commented 4 years ago

Before rendering the page, check if the item exists. If it doesn't, show a 404 page instead.

Fixes #3

tasn commented 4 years ago

Looks great, thanks a lot!

Just one stylistic comment: in EteSync we always have multilines ifs, so:

if (this.itemUndefined(itemUid)) {return PageNotFound()}

should be:

if (this.itemUndefined(itemUid)) {
  return PageNotFound();
}

Fix this, and it can be merged.

Great job, and thanks again!

tasn commented 4 years ago

Didn't mean to close it :facepalm:

ramzan commented 4 years ago

Fixed.