search

etesync / etesync-web

An EteSync web client
https://www.etesync.com
GNU Affero General Public License v3.0
244 stars 30 forks source link

Only 1st tag is applied #171

Closed shompoe closed 3 years ago

shompoe commented 3 years ago

Create a task in Tasks.org and apply more than one tag. Synchronise up and look in the web client. The task is shown only under the first tag but not the others.

tasn commented 3 years ago

Could you please paste here (feel free to censor here) the raw content of the task in question? You can do it opening the task in the web client, click on it -> change history -> the most recent change. Paste it here so we can see if the issue is in Tasks.org or the etesync web client.

Thanks!

shompoe commented 3 years ago

Just to clarify, since reseting the phone, solving sync issues, and re-creating the tasks list, this behaviour is still occuring.

Can you not reproduce it?

Mark Desrousseaux

18 Oct 2020, 08:01 by notifications@github.com:

Could you please paste here (feel free to censor here) the raw content of the task in question? You can do it opening the task in the web client, click on it -> change history -> the most recent change. Paste it here so we can see if the issue is in Tasks.org or the etesync web client.

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, > view it on GitHub https://github.com/etesync/etesync-web/issues/171#issuecomment-711126509> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AM6VTXYL6FCMQWTI5QS3NETSLKHEFANCNFSM4SUJCCRQ> .

tasn commented 3 years ago

I'd expect that. My request still stands. Could you please paste here the raw content of the task in question as requested above?

shompoe commented 3 years ago

Sorry, I thought I had sent it. #########################################################

Entry UID:
70a37ddb72e5dc5f03643ac23d1e3dfe6193884f93919bb08c86adf183edb046
Content:
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//EteSync//com.etesync.syncadapter/1.16.2 ical4j/2.2.6
BEGIN:VTODO
DTSTAMP:20201020T103626Z
UID:2030497105674122228
CREATED:20201020T103619Z
LAST-MODIFIED:20201020T103619Z
SUMMARY:Check hours
PRIORITY:9
STATUS:NEEDS-ACTION
RRULE:FREQ=WEEKLY;INTERVAL=1
CATEGORIES:Finance,Hide from week view until due date
DUE;TZID=Europe/London:20201022T190001
END:VTODO
BEGIN:VTIMEZONE
TZID:Europe/London
TZURL:http://tzurl.org/zoneinfo/Europe/London
X-LIC-LOCATION:Europe/London
BEGIN:DAYLIGHT
TZOFFSETFROM:+0000
TZOFFSETTO:+0100
TZNAME:BST
DTSTART:19810329T010000
RRULE:FREQ=YEARLY;BYMONTH=3;BYDAY=-1SU
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0100
TZOFFSETTO:+0000
TZNAME:GMT
DTSTART:19961027T020000
RRULE:FREQ=YEARLY;BYMONTH=10;BYDAY=-1SU
END:STANDARD
BEGIN:STANDARD
TZOFFSETFROM:-000115
TZOFFSETTO:+0000
TZNAME:GMT
DTSTART:18471201T000000
RDATE:18471201T000000
END:STANDARD
BEGIN:DAYLIGHT
TZOFFSETFROM:+0000
TZOFFSETTO:+0100
TZNAME:BST
DTSTART:19160521T020000
RDATE:19160521T020000
RDATE:19170408T020000
RDATE:19180324T020000
RDATE:19190330T020000
RDATE:19200328T020000
RDATE:19210403T020000
RDATE:19220326T020000
RDATE:19230422T020000
RDATE:19240413T020000
RDATE:19250419T020000
RDATE:19260418T020000
RDATE:19270410T020000
RDATE:19280422T020000
RDATE:19290421T020000
RDATE:19300413T020000
RDATE:19310419T020000
RDATE:19320417T020000
RDATE:19330409T020000
RDATE:19340422T020000
RDATE:19350414T020000
RDATE:19360419T020000
RDATE:19370418T020000
RDATE:19380410T020000
RDATE:19390416T020000
RDATE:19400225T020000
RDATE:19460414T020000
RDATE:19470316T020000
RDATE:19480314T020000
RDATE:19490403T020000
RDATE:19500416T020000
RDATE:19510415T020000
RDATE:19520420T020000
RDATE:19530419T020000
RDATE:19540411T020000
RDATE:19550417T020000
RDATE:19560422T020000
RDATE:19570414T020000
RDATE:19580420T020000
RDATE:19590419T020000
RDATE:19600410T020000
RDATE:19610326T020000
RDATE:19620325T020000
RDATE:19630331T020000
RDATE:19640322T020000
RDATE:19650321T020000
RDATE:19660320T020000
RDATE:19670319T020000
RDATE:19680218T020000
RDATE:19720319T020000
RDATE:19730318T020000
RDATE:19740317T020000
RDATE:19750316T020000
RDATE:19760321T020000
RDATE:19770320T020000
RDATE:19780319T020000
RDATE:19790318T020000
RDATE:19800316T020000
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0100
TZOFFSETTO:+0000
TZNAME:GMT
DTSTART:19161001T030000
RDATE:19161001T030000
RDATE:19170917T030000
RDATE:19180930T030000
RDATE:19190929T030000
RDATE:19201025T030000
RDATE:19211003T030000
RDATE:19221008T030000
RDATE:19230916T030000
RDATE:19240921T030000
RDATE:19251004T030000
RDATE:19261003T030000
RDATE:19271002T030000
RDATE:19281007T030000
RDATE:19291006T030000
RDATE:19301005T030000
RDATE:19311004T030000
RDATE:19321002T030000
RDATE:19331008T030000
RDATE:19341007T030000
RDATE:19351006T030000
RDATE:19361004T030000
RDATE:19371003T030000
RDATE:19381002T030000
RDATE:19391119T030000
RDATE:19451007T030000
RDATE:19461006T030000
RDATE:19471102T030000
RDATE:19481031T030000
RDATE:19491030T030000
RDATE:19501022T030000
RDATE:19511021T030000
RDATE:19521026T030000
RDATE:19531004T030000
RDATE:19541003T030000
RDATE:19551002T030000
RDATE:19561007T030000
RDATE:19571006T030000
RDATE:19581005T030000
RDATE:19591004T030000
RDATE:19601002T030000
RDATE:19611029T030000
RDATE:19621028T030000
RDATE:19631027T030000
RDATE:19641025T030000
RDATE:19651024T030000
RDATE:19661023T030000
RDATE:19671029T030000
RDATE:19711031T030000
RDATE:19721029T030000
RDATE:19731028T030000
RDATE:19741027T030000
RDATE:19751026T030000
RDATE:19761024T030000
RDATE:19771023T030000
RDATE:19781029T030000
RDATE:19791028T030000
RDATE:19801026T030000
RDATE:19811025T020000
RDATE:19821024T020000
RDATE:19831023T020000
RDATE:19841028T020000
RDATE:19851027T020000
RDATE:19861026T020000
RDATE:19871025T020000
RDATE:19881023T020000
RDATE:19891029T020000
RDATE:19901028T020000
RDATE:19911027T020000
RDATE:19921025T020000
RDATE:19931024T020000
RDATE:19941023T020000
RDATE:19951022T020000
END:STANDARD
BEGIN:DAYLIGHT
TZOFFSETFROM:+0100
TZOFFSETTO:+0200
TZNAME:BDST
DTSTART:19410504T010000
RDATE:19410504T010000
RDATE:19420405T010000
RDATE:19430404T010000
RDATE:19440402T010000
RDATE:19450402T010000
RDATE:19470413T010000
END:DAYLIGHT
BEGIN:DAYLIGHT
TZOFFSETFROM:+0200
TZOFFSETTO:+0100
TZNAME:BST
DTSTART:19410810T030000
RDATE:19410810T030000
RDATE:19420809T030000
RDATE:19430815T030000
RDATE:19440917T030000
RDATE:19450715T030000
RDATE:19470810T030000
END:DAYLIGHT
BEGIN:STANDARD
TZOFFSETFROM:+0100
TZOFFSETTO:+0100
TZNAME:BST
DTSTART:19681026T230000
RDATE:19681026T230000
END:STANDARD
BEGIN:STANDARD
TZOFFSETFROM:+0000
TZOFFSETTO:+0000
TZNAME:GMT
DTSTART:19960101T000000
RDATE:19960101T000000
END:STANDARD
END:VTIMEZONE
END:VCALENDAR
shompoe commented 3 years ago

In the raw data there are two tags but if I open the task in web client it only lists the first one.

shompoe commented 3 years ago

OK, so if I create a task with multiple tags from within the web client, then it is displayed correctly under those tags in the web client, but when it syncs back to tasks.org, it appears under a new tag, which is concatenated from the individual tag names separated with commas.

Example:
web client Tag1: apples Tag2: oranges tasks.org Tag1: apples, oranges

tasn commented 3 years ago

That's progress and may explain what is going on. When you say tasks.org: are you using the built-in tasks.org etesync support (that is, enter your credentials there), or the one that integrates with the etesync app?

shompoe commented 3 years ago

Integrating with etesync app now.

Mark Desrousseaux

20 Oct 2020, 13:03 by notifications@github.com:

That's progress and may explain what is going on. When you say tasks.org: are you using the built-in tasks.org etesync support (that is, enter your credentials there), or the one that integrates with the etesync app?

— You are receiving this because you authored the thread. Reply to this email directly, > view it on GitHub https://github.com/etesync/etesync-web/issues/171#issuecomment-712800696> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AM6VTX5BSASZRWEDNNIAWQLSLV4ARANCNFSM4SUJCCRQ> .

tasn commented 3 years ago

Could you please share the raw entry of a multi-tag task created from Tasks.org? Thanks!

shompoe commented 3 years ago

Yep. That's what I shared above.

tasn commented 3 years ago

Can you please share the other one then? The one that was working in the web client but not in tasks.org?

shompoe commented 3 years ago 
Entry UID:
9339b60aa02de4777f14628a42e500e922621c51f0d6ff56e93ac497928afaaf
Content:
BEGIN:VCALENDAR
VERSION:2.0
PRODID:+//IDN bitfire.at//ical4android
BEGIN:VTODO
DTSTAMP:20201020T113337Z
UID:eafa21d4-19b0-4a23-900f-2e97e9080b4c
LAST-MODIFIED:20201020T113123Z
SUMMARY:Test
STATUS:COMPLETED
CATEGORIES:Finance\,House and Garden
END:VTODO
END:VCALENDAR

Comma is escaped out?

tasn commented 3 years ago

I don't see an escape (maybe it's because you are not pasting it as part of a code tag? could you maybe edit your posts), here is what I'm seeing:

 CATEGORIES:Finance,Hide from week view until due date
vs
 CATEGORIES:Finance,House and Garden

Looks the same (with regarding to the commas), no?

shompoe commented 3 years ago 
Entry UID:
aa7297141be8a5638569ec5af1f62af1cee42317867fcd4dcceeb402a58666c4
Content:
BEGIN:VCALENDAR
PRODID:-//iCal.js EteSync iOS
VERSION:2.0
BEGIN:VTODO
UID:4e6c3d6a-8463-4a32-8851-e466bb2bcf9f
SUMMARY:Test2
STATUS:NEEDS-ACTION
PRIORITY:0
CATEGORIES:Car\,Shopping
LOCATION:
DESCRIPTION:
LAST-MODIFIED:20201020T141754
END:VTODO
END:VCALENDAR
shompoe commented 3 years ago

Strange, Github is removing the backslash before the comma when I commit the comment

tasn commented 3 years ago

I edited your posts to enclose your pastes in code blocks, which is then not escaped by Github, and I can now see the issue. Seems to be a bug in the web app indeed.

shompoe commented 3 years ago

At last I've been helpful as opposed to wasting your time!  Lol.

Mark Desrousseaux

21 Oct 2020, 09:45 by notifications@github.com:

I edited your posts to enclose your pastes in code blocks, which is then not escaped by Github, and I can now see the issue. Seems to be a bug in the web app indeed.

— You are receiving this because you authored the thread. Reply to this email directly, > view it on GitHub https://github.com/etesync/etesync-web/issues/171#issuecomment-713412089> , or > unsubscribe https://github.com/notifications/unsubscribe-auth/AM6VTX5EXQ4ER4BCVEGG443SL2NSLANCNFSM4SUJCCRQ> .

tasn commented 3 years ago

I just deployed a new version to pim.etesync.com (the EteSync 2.0 one!). Could you please check to see if that fixes it for you? You may need to force refresh the page to make sure you get the latest version, and you may need to create a new task/edit the tags to make sure old ones are fixed.

tasn commented 3 years ago

Edit: actually, deployed it to the legacy one too.

shompoe commented 3 years ago

Uh oh..... As soon as i click over from default calendar view to tasks I get this........

Something went wrong!
Cannot read property 'getValues' of null
TypeError: Cannot read property 'getValues' of null
    at t.get (https://client.etesync.com/static/js/main.349de1e8.chunk.js:1:150258)
    at https://client.etesync.com/static/js/main.349de1e8.chunk.js:1:229997
    at Array.filter (<anonymous>)
    at Qa (https://client.etesync.com/static/js/main.349de1e8.chunk.js:1:229968)
    at Jo (https://client.etesync.com/static/js/2.012435f0.chunk.js:2:1378751)
    at gs (https://client.etesync.com/static/js/2.012435f0.chunk.js:2:1425157)
    at uc (https://client.etesync.com/static/js/2.012435f0.chunk.js:2:1417690)
    at sc (https://client.etesync.com/static/js/2.012435f0.chunk.js:2:1417615)
    at $s (https://client.etesync.com/static/js/2.012435f0.chunk.js:2:1414624)
    at https://client.etesync.com/static/js/2.012435f0.chunk.js:2:1366009
shompoe commented 3 years ago

Same on Etesync 2.0......

Something went wrong!
Cannot read property 'getValues' of null
TypeError: Cannot read property 'getValues' of null
    at t.get (https://pim.etesync.com/static/js/main.f1e22785.chunk.js:1:146343)
    at https://pim.etesync.com/static/js/main.f1e22785.chunk.js:1:210406
    at Array.forEach (<anonymous>)
    at https://pim.etesync.com/static/js/main.f1e22785.chunk.js:1:210376
    at Jo (https://pim.etesync.com/static/js/2.e77744e8.chunk.js:2:1304581)
    at Ra (https://pim.etesync.com/static/js/2.e77744e8.chunk.js:2:1313485)
    at Ta (https://pim.etesync.com/static/js/2.e77744e8.chunk.js:2:1313304)
    at Oa (https://pim.etesync.com/static/js/2.e77744e8.chunk.js:2:1312987)
    at gs (https://pim.etesync.com/static/js/2.e77744e8.chunk.js:2:1354535)
    at uc (https://pim.etesync.com/static/js/2.e77744e8.chunk.js:2:1343520)
tasn commented 3 years ago

My bad, please try again.

shompoe commented 3 years ago

All of my tasks created in tasks.org are now displaying correctly in web client. However, when I now create a new task in the web client, it's tags are not getting saved. I looked at the raw task data to verify this.

tasn commented 3 years ago

Sorry for the sloppiness, I'm doing a few things in parallel. It should be good now. I hope. :)

shompoe commented 3 years ago

Hmmmmmm, nope, still not right I'm afraid.

error
tasn commented 3 years ago

OK, I'll stop wasting your time, hehe. I'm on it. :P

tasn commented 3 years ago

I actually tested it now and it works. Please report back. :) (Just deployed a new version)

shompoe commented 3 years ago

Touché!

By the way, is it intended that when you restore state from the journal in web client it restores everything from the selected entry to the latest entry? Because is android client you can restore state of individual entries on their own, which is the way I would have expected it to work.

tasn commented 3 years ago

OK, so works? Can I push the changes?

The "restore state" doesn't restore the state of a specific item, but rather tries to rollback all of the changes in the list up until that item. It's a bit different than to Android, but it was removed in EteSync 2.0 (at least should have been).

shompoe commented 3 years ago

Not sure, when I click "Save" the save button briefly flashes but then nothing happens at all, so still can't create any tasks.

tasn commented 3 years ago

So weird, as it works here. :| Are you testing with etesync v1, v2 or both?

shompoe commented 3 years ago

Version 1.0 (in brave browser)

shompoe commented 3 years ago

V2 is also the same.

tasn commented 3 years ago

Ahhh, it's my bad actually, I tested the wrong thing. Fixing and testing again.

tasn commented 3 years ago

OK, I now tested the right thing. I previously tested editing a task with existing tags. I now also tested creating tags for event without any. :)

shompoe commented 3 years ago

Looking good.

Thanks for fixing. If I notice anything else I'll let you know.

tasn commented 3 years ago

Great! And sorry for the ordeal. As I said, I was juggling a lot of things today in parallel and didn't have time to properly test things. Ended up costing more time in the end. As such things always do... :)