etesync / etesync-web

An EteSync web client
https://www.etesync.com
GNU Affero General Public License v3.0
243 stars 30 forks source link

Improve Layout of ContactEdit #241

Closed b-erhart closed 2 years ago

b-erhart commented 2 years ago

I thought the current ContactEdit screen looks a bit messy, since the alignments and margins were a bit off in some places. So I tried to improve the situation a little.

This is a short summary of the changes I made:

Obviously, design stuff is a pretty subjective thing. So I'm not sure if you like this kind of layout or if this is the design direction you want to go in. This is simply a suggestion and I am happy to make adjustments.

Here is a small comparison: Before:

ContactEdit_before

After:

ContactEdit_after_new
b-erhart commented 2 years ago

Also, I tried to follow the general style of the existing code. But since this is my first PR here, I'm not sure if I managed to do that everywhere. Please tell me if something doesn't fit and I will change it.

tasn commented 2 years ago

Oh, why did you close it? Sorry I missed it until now. Want me to take a look?