search

etesync / etesync-web

An EteSync web client
https://www.etesync.com
GNU Affero General Public License v3.0
247 stars 32 forks source link

Add support for recurring events #50

Open neurokrish opened 5 years ago

neurokrish commented 5 years ago

Can't seem to find a way to add recurring events. Will be very useful for events like birthdays..

tasn commented 5 years ago

Definitely. FWIW they currently show correctly, you just can't edit them.

neurokrish commented 5 years ago

Doesn't work for me. I have a birthday calendar with recurring yearly events imported. When I click those events, it throws up an error saying "something went wrong" and that an "event should be defined!" with something under "stack trace". No such errors occur for regular calendar events. Am I missing something?

neurokrish commented 5 years ago

OK, I misread your comment. Looks like you know the issue. Yes, I can see the recurring events just fine but when I click on it, I get an error. Guess that's what you meant by "can't edit them". Hope you can push a fix for this.

tasn commented 5 years ago

I'm actually not familiar with the crash. It should show a nice error message. Could you maybe put the backtrace here? Thanks!

Nuntius0 commented 5 years ago 
Error: Event should be defined!
    at t.value (https://client.etesync.com/static/js/main.59c3899d.chunk.js:1:36954)
    at Mo (https://client.etesync.com/static/js/2.88819104.chunk.js:1:763666)
    at Co (https://client.etesync.com/static/js/2.88819104.chunk.js:1:763459)
    at Io (https://client.etesync.com/static/js/2.88819104.chunk.js:1:767316)
    at Ya (https://client.etesync.com/static/js/2.88819104.chunk.js:1:786901)
    at qa (https://client.etesync.com/static/js/2.88819104.chunk.js:1:787285)
    at Ts (https://client.etesync.com/static/js/2.88819104.chunk.js:1:793831)
    at ks (https://client.etesync.com/static/js/2.88819104.chunk.js:1:793211)
    at Ds (https://client.etesync.com/static/js/2.88819104.chunk.js:1:799862)
    at Tn (https://client.etesync.com/static/js/2.88819104.chunk.js:1:732363)

I'm getting this too. Weirdly enough, only for some recurring events but not all, and sometimes only when clicking on the event from the week view but not from the month view.

tasn commented 5 years ago

This is a recent regression, I swear it used to work. I wonder what it's about.

tasn commented 5 years ago

Btw, @Nuntius0, let's talk about this issue in #56. This ticket is about adding a way to add recurring events.