etesync / server

The Etebase server (so you can run your own)
https://www.etesync.com
GNU Affero General Public License v3.0
1.48k stars 75 forks source link

Create python package #140

Closed Xiretza closed 2 years ago

Xiretza commented 2 years ago

This is quite a big one, so it probably makes sense to review it commit-by-commit (there shouldn't be any overlap).

Summarized:

tasn commented 2 years ago

There's a conflict. The main question though, before I review it: why do we want it to work as a python package? Is this people will actually use?

Xiretza commented 2 years ago

I would think so. Not only would it allow using pip install https://github.com/etesync/server (or even pip install etebase_server if it's pushed to pypi), it also makes distro packaging a lot easier because it can be handled like any other python package.

tasn commented 2 years ago

Cool, that's fair. OK. Will review this once we review and merge all the others as I don't want any conflicts here.

Xiretza commented 2 years ago

Rebased.

tasn commented 2 years ago

Merged, thanks a lot! Please take extra care testing it to make sure we didn't break anything, though it looks good for all I can see.