search

etetoolkit / ete

Python package for building, comparing, annotating, manipulating and visualising trees. It provides a comprehensive API and a collection of command line tools, including utilities to work with the NCBI taxonomy tree.
http://etetoolkit.org
GNU General Public License v3.0
792 stars 214 forks source link

[Potential Bug] ClusterNode/ClusterTree does not have a name argument #363

Open jolespin opened 6 years ago

jolespin commented 6 years ago

I noticed that ClusterNode and ClusterTree alias do not have name arguments but they do have a .name attribute that can be set. Is this intentional?

Would it be possible to add the name argument into the instance as it's being called like Tree and PhyloTree? 

ete3.__version__
'3.1.1'
jhcepas commented 6 years ago

we haven't updated ClusterNode for a long time and you are right that those classes are missing arguments. Not only name, but also support, format, and quoted_node_names. I will mark this as a bug, and I'll be happy to take any pull request fixing it if that happens before I can find time to fix it myself thanks!

jolespin commented 6 years ago

I can try and give it a shot ! Can we do a super().__init style option to inherit everything from TreeNode?

jhcepas commented 6 years ago

the inherit should be already in place. we just need to update the argument list