search

etetoolkit / ete

Python package for building, comparing, annotating, manipulating and visualising trees. It provides a comprehensive API and a collection of command line tools, including utilities to work with the NCBI taxonomy tree.
http://etetoolkit.org
GNU General Public License v3.0
773 stars 216 forks source link

Copy over svg colors to smartview module #699

Closed sirno closed 10 months ago

sirno commented 11 months ago

Hi,

this PR fixes an ImportError in the smartview.layouts module. It uses a copy of the treeview.svg_colors module in smartview.renderers.

It's also possible to move the function into an ete4.utils module or so.

jordibc commented 10 months ago

Hi @sirno ,

We have tried to fix this and your other related PRs with commit 1c3f9d9946f .

In particular, the code for svg_colors.py is now shared by smartview and treeview by means of ete4/utils.py.

I'm copying the same text on them and closing them, but feel free to comment or let us know if anything is not working properly.

Thanks!