[iOS Bootcamp] Week1 Assigment (Rotten Tomatoes app) - Review my app

[etexier]

My app is complete please review. /cc @codepathreview

[etexier]

One major issue I hit late yesterday: I am not using a storyboard, but IB. All the tutorial were using storyboard, so I had to proceed with my own hacks: Placing the search bar on top of the table view, kind of mess up the with the navigation bar. One solution I found was to include the search bar inside the navigation bar with the option. But then both the searchbar view and the navigation bar's search bar conflicted on the UI. Still, the search functionality works, though the UI experience is awful.

[codepathreview]

:+1: nice work. The point of this homework was to explore a simple example of a full MVC application with a RESTful API. For each point in the homework feedback checklist, I'll either confirm that you're on the right track with the implementation, or I'll provide some feedback:

• love Rest2Mobile
• Nice code styling. The New York Times has a good summary of appropriate Objective-C coding conventions, you should take a quick look here.
• Nice work with the header files. You should always try to minimize the number of properties and methods in the header files and move all private properties and methods into the class extension (the @interface block in the .m file).
• Nice work implementing the Movie model.
• Your custom Movie cell should have a property called movie. In the custom setter of movie, you should configure the various labels and images. This decouples your custom cells from the table view controllers.
• Nice work loading the images asynchronously.
• Nice work setting up the proper modes for the images so that they are not stretched.
• Nice work implementing the error message on network failure.

In general, you should challenge yourself to create visually polished applications. That's where you'll find all the rough edges of the iOS framework and earn the next level of mastery.

--dirk

[etexier]

Thanks Dirk, /cc @codepathreview

I am actively involved in the rest2mobile project and I thought it would be a good use case. It also allowed me to fix a few bugs in rest2mobile as well :)

I appreciate your comments, I am still a rookie in app UI building and learning. Yes, I should have moved the cell setup inside the cell impl itself: just run out of time to clean up everything :) I'll take a look at the NYT code styling too.

Have a nice week-end (mine is completely booked with yelp app) -manu