etf-validator / etf-webapp

:earth_africa: :mag: ETF is an open source testing framework for spatial data and services
https://www.etf-validator.net
European Union Public License 1.2
18 stars 19 forks source link

Test Object data size not calculated #101

Closed jonherrmann closed 7 years ago

jonherrmann commented 7 years ago

Works neither for referenced or uploaded data.

Example:

"testObjects": {
        "TestObject": {
          "id": "EIDa2d12cbf-f8f1-4a4f-8368-829ff546520e",
          "remoteResource": "https://raw.githubusercontent.com/inspire-eu-validation/ets-test-resources/master/dataset/002-au-errors/testobject/002-au-errors.xml",
          "label": "002-au-errors.xml",
          "description": "Web Test Object",
          "version": "1.0.0",
          "author": "unknown",
          "creationDate": "2017-04-06T08:32:18.709Z",
          "lastEditor": "unknown",
          "lastUpdateDate": "2017-04-06T08:32:19.15Z",
          "testObjectTypes": {
            "testObjectType": {
              "href": "http://X/etf-webapp/v2/TestObjectTypes/5a60dded-0cb0-4977-9b06-16c6c2321d2e.json"
            }
          },
          "ResourceCollection": {
            "resource": [
              {
                "name": "download.1",
                "href": "file:/etf/testdata/002-au-errors.xml-a2d12cbf-f8f1-4a4f-8368-829ff546520e/"
              },
              {
                "name": "data",
                "href": "https://raw.githubusercontent.com/inspire-eu-validation/ets-test-resources/master/dataset/002-au-errors/testobject/002-au-errors.xml"
              }
            ]
          },
          "Properties": {
            "property": [
              {
                "name": "temporary",
                "$": true
              },
              {
                "name": "indexed",
                "$": false
              },
              {
                "name": "files",
                "$": 1
              },
              {
                "name": "size",
                "$": 0
              },
              {
                "name": "sizeHR",
                "$": "0 bytes"
              },
              {
                "name": "data.downloadable",
                "$": false
              }
            ]
          }
        }
      },
carmenvandeloo commented 7 years ago

@jonherrmann Also note that the TestTaskResults are not correct.

When looking at the TestTaskResult.xml for the same combination of file and ETS in the ets-test-resources repository, f.e. assertion EIDde605406-7883-458f-8ae1-59f9b64928e4 should be as below while here it is marked PASSED. I believe that something still goes wrong in the loading of the file and the features are not discovered/evaluated. I will email you the full reponse body of the Get TestTaskResult.

<TestAssertionResult id="EID7510c58c-a7e7-4a30-8256-be48d52e5b2c">
  <messages>
    <message ref="TR.featuresWithErrors">
      <translationArguments>
        <argument token="count">1</argument>
      </translationArguments>
    </message>
    <message ref="TR.constraintViolation">
      <translationArguments>
        <argument token="gmlid">NC.MT01407</argument>
        <argument token="filename">002-au-errors.xml</argument>
        <argument token="featureType">AdministrativeUnit</argument>
        <argument token="additionalInfo">Reference to: '#NC.MT01408'.</argument>
        <argument token="constraint">No unit at lowest level can associate units at lower level.</argument>
      </translationArguments>
    </message>
  </messages>
  <parent ref="EIDec6cd97f-f5b1-4da8-b7a8-c2f7ea6fb24f"/>
  <resultedFrom ref="EID44c654af-5131-4d16-b51d-30ba80311053"/>
  <startTimestamp>2016-11-18T17:30:22.807+01:00</startTimestamp>
  <duration>1</duration>
  <status>FAILED</status>
</TestAssertionResult>
jonherrmann commented 7 years ago

Thanks for the hint @carmenvandeloo !

I have an idea what's going wrong here.

jonherrmann commented 7 years ago

The issue occurred on Linux machines when uploaded/downloaded files where moved from one mounted volume to another. 1st beta release version was also affected.

Internal note: updated dev and dev7

jonherrmann commented 7 years ago

Added an API test