search

etf-validator / etf-webapp

:earth_africa: :mag: ETF is an open source testing framework for spatial data and services
https://www.etf-validator.net
European Union Public License 1.2
19 stars 19 forks source link

Auto configuration of etf.testobject.max.size not working correctly #152

Closed jonherrmann closed 5 years ago

jonherrmann commented 6 years ago

2018-03-23 10:55:27.412 [main] INFO d.i.e.w.c.EtfConfigController - etf.testobject.max.size = etf.max.upload.size

2018-03-23 10:55:27.413 [main] INFO d.i.e.w.c.EtfConfigController - etf.max.upload.size = 35609048772

2018-03-23 10:55:27.411 [main] INFO d.i.e.w.c.EtfConfigController - Automatic setting max upload size based on presumable free memory 2018-03-23 10:55:27.411 [main] WARN d.i.e.w.c.EtfConfigController - The value of the etf.testobject.max.size property should be set to value greater than the value 35609048772 of the etf.max.upload.size property.

de.interactive_instruments.exceptions.config.InvalidPropertyException: Configured property "etf.testobject.max.size" is not a number

https://github.com/interactive-instruments/etf-webapp/blob/65eafd0691da491e4bd9691e8b3a8f6e864fa6be/src/main/java/de/interactive_instruments/etf/webapp/controller/EtfConfigController.java#L393-L405

Missing getProperty() call: configProperties.setProperty(ETF_TEST_OBJECT_MAX_SIZE, ETF_MAX_UPLOAD_SIZE);

https://github.com/interactive-instruments/etf-webapp/blob/65eafd0691da491e4bd9691e8b3a8f6e864fa6be/src/main/java/de/interactive_instruments/etf/webapp/controller/EtfConfigController.java#L131

https://github.com/interactive-instruments/etf-webapp/blob/65eafd0691da491e4bd9691e8b3a8f6e864fa6be/src/main/java/de/interactive_instruments/etf/webapp/controller/EtfConfigController.java#L141