etf-validator / etf-webapp

:earth_africa: :mag: ETF is an open source testing framework for spatial data and services
https://www.etf-validator.net
European Union Public License 1.2
19 stars 19 forks source link

Upload fails for XML documents: test object could not be determined #180

Closed thijsbrentjens closed 5 years ago

thijsbrentjens commented 6 years ago

Prerequisites for a bug report

If your service is protected or you have confidential data that you cannot upload here, you can request an email address to which you can send URLs / files. Please note that issues cannot be fixed for services/datasets that we cannot access.

Description

On our (beta) instance of the ETF validator I've created a validator on an XML spec that does contain GML features, but not in default FeatureCollections. Sample doc is attached, but all other docs

I've tried several Test object types, but even with the Set of documents, the upload failes.

Operating systems and browser

Steps to Reproduce

  1. Go to: http://beta.validatie.geostandaarden.nl:8080/etf-webapp-2.0.0/
  2. Choose validator StUF-Geo IMGeo versie 1.3 Geo-BOR (inclusief aanvullendeElementen), Run all dependencies
  3. Upload the file attached with this issue

Expected behavior: [Which behavior you expected to see instead and why.] An uploaded file, to start testing afterwards.

Actual behavior: [Describe the behavior you observed after following the steps] Upload failed and can't start the test.

jonherrmann commented 6 years ago

Hi @thijsbrentjens,

this is not possible, the Set of documents and Set of XML documents test object types cannot be used anymore. This is an issue in the documentation.

I see two solutions:

thijsbrentjens commented 6 years ago

O, that's a pity.

I can imagine that if a Test Object Type (TOT) is too generic it may lead to issues. I think that a specific TOT is the best for the models we have at Geonovum. These models are GML based, but use different containers for the featurecollection.

Correct that I only need to make changes to this class: https://github.com/etf-validator/etf-stdtot/blob/master/src/main/java/de/interactive_instruments/etf/StdTestObjectTypes.java?

And tests?

thijsbrentjens commented 6 years ago

@jonherrmann just to inform you: I've created a fork and custom Test Object Types. We can use this approach, but nicer would be that we don't need changes in the sofwtware, but could do this by configuration as suggested in the ETF docs (http://docs.etf-validator.net/v2.0/Developer_manuals/Developing_Executable_Test_Suites.html#basex-test-object-types):

In future versions of ETF it is planned that new Test Object Types may be specified by a test developer defined and declared in XML in the include-metadata directory.

For now it works, so we can close this issue if you like.