search

etf-validator / etf-webapp

:earth_africa: :mag: ETF is an open source testing framework for spatial data and services
https://www.etf-validator.net
European Union Public License 1.2
19 stars 19 forks source link

Eip 48 - concurrency configuration parameters #193

Closed carlospzurita closed 5 years ago

carlospzurita commented 5 years ago

Fixing for https://github.com/etf-validator/governance/issues/48

We added in the configuration files a couple of parameters to control the queue and maximum number of threads. This sets to a default of the number of processors for maximum thread number, and 3 times this number for the queue size

carlospzurita commented 5 years ago

The remaining conflicts are caused by the addition of our own code for the solution. The original code from the next branch is kept by this merge.

carlospzurita commented 5 years ago

As far as we see, it has been planned for milestone 2.1.0. Just to clarify, from our point of view, pending conflicts must be addressed by the TC at the time of integration. If any additional action is needed from our side, please, let us know.

carlospzurita commented 5 years ago

We followed you're recommendations to merge the next branch on this one and applied ./gradlew spotlessApply. We now see some quality isses from the Codacy bot that affect old code. How shall we proceed with this PR?

carlospzurita commented 5 years ago

We have pushed the requested changes on this pull request. Some issues have appeared from the codacy report, but we think that they can be marked as solved, as we have followed the same code style and practices that were present on the original code. However, if you have any feedback, or see fit to make more changes, please let us know.