search

etf-validator / etf-webapp

:earth_africa: :mag: ETF is an open source testing framework for spatial data and services
https://www.etf-validator.net
European Union Public License 1.2
18 stars 19 forks source link

Download and View Services Test Suites does not recognize services URL #195

Closed carlospzurita closed 5 years ago

carlospzurita commented 5 years ago

Description

There is some inconsistency in the test the services URL are subjected to, in order to detect if they are a Test Object Type supported by the selected tests. Some conformance classes work with just the host and context of the service, others need the full GetCapabilities request in order to start.

For example, in WMS, you can provide an URL without parameters (for example http://www.ign.es/wms-inspire/mapa-raster) and the test will recognize it as a valid test object type. This also works with an URL with GetCapabilities parameter.

If you try the same on WMTS, with this URL http://www.ign.es/wmts/pnoa-ma show this error message. Captura de pantalla de 2019-03-27 14-00-50 If you provide the GetCapabilities parameters (http://www.ign.es/wmts/pnoa-ma?request=GetCapabilities&service=WMTS), it works just fine.

Operating systems and browser

This issue happens in all browsers. Tested in Ubuntu 18. We attach the ETF log with this issue etf.log

Steps to Reproduce

1.Start a WMTS Test Run

  1. Provide an URL with just the host and the context of the service
  2. Error appears both in UI and etf.log

Expected behavior: The tests should start either with or without parameters on the URL Actual behavior: Some Test Suites accept the URL without parameters and other can't recognize the service URL.

jonherrmann commented 5 years ago

Hi Carlos,

when developing the test object detector, we did not take WMTS handling into account (WMS + WMTS validation were no requirement in first version). You are welcome to create a PR in the etf-stdtot repo and add the default query with the setDefaultPathAndQuery() method. Please see this WMS example: https://github.com/etf-validator/etf-stdtot/blob/master/src/main/java/de/interactive_instruments/etf/StdTestObjectTypes.java#L232

Cheers Jon