etf-validator / governance

ETF Steering Group and the Technical Committee documents
1 stars 2 forks source link

Adding support for View Services (WMS & WMTS) ETS #36

Closed carlospzurita closed 2 years ago

carlospzurita commented 6 years ago

ETF Improvement Proposal (EIP)

Background and Motivation:

In the development of new ATS and ETS for the Technical Guidelines 2.0 of INSPIRE, the ETF has been found in need of some components for the View Services validations in the SOAP UI integration, as discussed in https://github.com/etf-validator/etf-webapp/issues/149 .

Proposed change

To be able to develop the ETS for WMS and WMTS, the following classes need to be included in the de.interactive_instruments.xtf.wms package in the etf-sui-owsgtl library.

Also the correspondant classes for WMTS package.

Alternatives

The steps taken so far in the analysis of this issues have been:

  1. Analysis of the etf-sui-owsgtl library
  2. Analysis of the Download services implementation
  3. Definition of required classes for the WMS & WMTS protocols, following the Technical Guidelines and replicating the model of Download Services
  4. Implementation of said classes, using stubs methods and datatypes where needed

Currently, we are following an iterative process to detect problems, pindown the needed changes and adding the missing features running ETSs against these implementations; streamlining in each iteration the process, to finally have a reproducible workflow for new protocols or INSPIRE themes.

Funding

This development is funded by JRC

jonherrmann commented 6 years ago

Could you please describe a bit more detailed why the following classes would be required and what there responsibilities would be:

Also the correspondant classes for WMTS package.

Can you already foresee what new classes for a WMTS would be required that could not be used from the WMS?

carlospzurita commented 6 years ago

Hi Jon, thanks for your comments. Here are some clarifications:

For WMTS, data holders and request would be different from wms, because it has another format response and another parameters. therefore, new classes and methods should developed. We are still in the process of analyzing what the classes, methods and attributes should be needed, but the classes

could be reused for this service.

If you have any additional comments, or like further clarifications, please let us know.

jonherrmann commented 6 years ago

Hi Carlos, thanks for the information.

I was expecting that the classes have any other function than just holding data. Several years ago, we implemented some simple WMS tests in another project and extended the library for that. All that was needed was the layer class. I think it is not necessary to create objects for functionalities that can be accessed directly in SoapUI as the ContactInformation. But this aspect is not that important to me.

We are developing the GetMapRequest class extending HttpRequest, in the same manner that is done on the WFS package, for example GetFeatureRequest

OK, but the INSPIRE tests do not use the GetFeatureRequest object.

jenriquesoriano commented 6 years ago

To do: Analyze the WFS behaviour Analyze the WMS ETS from https://github.com/Geonovum/etf-test-projects-inspire/tree/master/src

carlospzurita commented 5 years ago

We checked the provided code from Geonovum, where everything is encapsulated in a single SoapUI project. Although it seems good to run a test this way, we think that for the sake of code maintainability and clarity, the code should be more modular, as other components of the ETF.

OK, but the INSPIRE tests do not use the GetFeatureRequest object.

We are aware that this method is not used by the INSPIRE tests, is just an auxiliary method for handling HttpRequest to a WFS. We are just replicating the work methodology for WMS.

jonherrmann commented 2 years ago

https://github.com/etf-validator/etf-sui-ae/pull/4

jonherrmann commented 2 years ago

Implemented in Version 2.1.0