search

etf-validator / governance

ETF Steering Group and the Technical Committee documents
1 stars 2 forks source link

added minutes of SG 8th meeting #56

Closed MarcoMinghini closed 5 years ago

michellutz commented 5 years ago

@MarcoMinghini It looks like you have to re-commit the minutes, once you have created and assigned a GPG key to your account.

MarcoMinghini commented 5 years ago

@michellutz I thought this is what I did: https://github.com/etf-validator/governance/pull/56/checks But since it was the first time I used the GPG key, probably I have missed something - I'll take a look and try to commit again.

MarcoMinghini commented 5 years ago

@michellutz @cportele @jonherrmann I made again the signed commit and the PR, let's see if it works after your reviews.

jonherrmann commented 5 years ago

@MarcoMinghini you can check this by viewing your commit history:

https://github.com/etf-validator/governance/pull/56/commits

GPG-signed commits have a "verified" badge, see here:

https://github.com/etf-validator/governance/commits/master

Maybe a problem with your GIT tool? For example, the last time I used GitHub Desktop, it did not support commit signing.