Closed carlospzurita closed 2 years ago
Please open a Pull Request. EIPs are not the right place to review code.
At the moment we are not using GmlGeoX version 1 and I will not run any manual tests with it. So please make sure that your PR code is covered by unit tests.
Implemented in Version 2.1.0
Background and Motivation:
In the PR https://github.com/deegree/deegree3/pull/1034 on the deegree repository, two auxiliar methods have been added to check the ring orientation:
insInterior
andisExterior
, taking into account if the patch being validated is clockwise or not. This has been included on the release 3.4.12 that was integrated in the ETF in PR https://github.com/etf-validator/etf-gmlgeox/pull/25.Proposed change
The next step would be to include this methods on the etf-gmlgeox module (version 1), in the class
nl.vrom.roo.validator.core.dom4j.handlers.GMLValidationEventHandler
. The proposal is to modify the current methodsexteriorRingOrientation
andinteriorRingOrientation
to make use of these methods, instead of checking directly if the geometry is clockwise and relying on deegree for this checkAlternatives
Funding
This development is funded by JRC
Additional information
This development is intended for the currents INSPIRE datasets ETS that use BaseX. Given that the module is moving past this in the new ETF release, it was agreed that this will be kept on a separate "legacy" version of etf-gmlgeox