Open GregTheGreek opened 5 years ago
what's the difference between #66 and #67 and isn't supply cap already implemented and activated? could we have one ticket for each issue with discover? this would be a mess otherwise.
supply cap should be implemented, but I want to double check, never know what you'll find.
I think everything is implemented. IF anyone discovers they're not correctly done we can break it out.
Indeed,
As I see it, the important idea of this issue is to flag potential 'overwrites' or ignorances of these pre-existing features during the implementation of the next fork (Atlantis) features, as was the case with #67.
Hotspots with this might include
statedb.IntermediateRoot(false)
). This is a tricky one because it is unclear exactly how partially or wholly this feature was already partially implemented. Not pretty, mostly edge case relevant, lots of tendrils. Medium spots:
status
encoding; this was preexistingly partially implemented for storage, but not for consensus. afair features were in place to satisfy the eth API specs for ETH interoperability on-the-fly, w/o extending support through wire protocol. are there adequate unit tests for these new RLP encoding/decoding cases?Cold spots I would expect (places which can be relatively satisfactorily unit-testable and/or comprehensively integration testable):
@meowsbits thanks for this beautifully written comment, I think its worth breaking that into its own issue(s) - I'll get to that tomorrow
In light of #66 #67 there was a communication breakdown of a few ETC specific forks that occurred. @YazzyYaz pointed me to a couple things we should double check.