eth-classic / go-ethereum

Go implementation of the Ethereum Classic protocol. Moved:
https://github.com/etclabscore/go-ethereum
GNU Lesser General Public License v3.0
6 stars 6 forks source link

Overwrites and ignorances of pre-existing features during the implementation of Atlantis #68

Open GregTheGreek opened 5 years ago

GregTheGreek commented 5 years ago

In light of #66 #67 there was a communication breakdown of a few ETC specific forks that occurred. @YazzyYaz pointed me to a couple things we should double check.

soc1c commented 5 years ago

what's the difference between #66 and #67 and isn't supply cap already implemented and activated? could we have one ticket for each issue with discover? this would be a mess otherwise.

GregTheGreek commented 5 years ago

supply cap should be implemented, but I want to double check, never know what you'll find.

I think everything is implemented. IF anyone discovers they're not correctly done we can break it out.

meowsbits commented 5 years ago

Indeed,

As I see it, the important idea of this issue is to flag potential 'overwrites' or ignorances of these pre-existing features during the implementation of the next fork (Atlantis) features, as was the case with #67.

Hotspots with this might include

Medium spots:

Cold spots I would expect (places which can be relatively satisfactorily unit-testable and/or comprehensively integration testable):

GregTheGreek commented 5 years ago

@meowsbits thanks for this beautifully written comment, I think its worth breaking that into its own issue(s) - I'll get to that tomorrow