Closed simonpintarelli closed 1 year ago
can we merge ?
Looks good to me. Just one thing: do we want to allow COSMA_BLAS_VENDOR_LIST to be NONE
? I guess this is required. Alternatively, we can add some basic implementation for local gemm calls, but there is probably no need for it.
Looks good to me. Just one thing: do we want to allow COSMA_BLAS_VENDOR_LIST to be
NONE
? I guess this is required. Alternatively, we can add some basic implementation for local gemm calls, but there is probably no need for it.
I use OFF instead of NONE after following both simon and your suggestion.
It is off
by default and an error message will show up if COSMA_BLAS=OFF
so the user is warmed. It means that this parameter should be explicitly set during compilation time. It is also the old behavior because we did not want to complicate the spack recipe too much between versions.
If COSMA_BLAS=CUDA,ROCM
then the BLAS implementation is the scalapack one if COSMA_SCALAPACK=MKL,CRAY_LIBSCI,CUSTOM
.
if you agree I will create a tagged version of COSMA as well and create a PR for spack
Sure, once you believe it's ready, feel free to merge it and make a new release.
For the release, just pay attention to the following:
.tar.gz
and .zip
as assets to the release.
Authors: