Fix empty case for `copy`

albestro commented 10 months ago

Fix problem realised in https://github.com/eth-cscs/DLA-Future/pull/951#pullrequestreview-1753551403 with empty sub-matrices.

Add quick return for empty case
Add some empty test-cases
Extend copy assertions to cover both local and distributed case

Other changes required:

align_sub_rank_index changes and improvements
same_process_grid should work also with Matrices on different Devices
MatrixBase::source_rank_index() was missing (there was just deprecated camelCase version)

albestro commented 10 months ago

cscs-ci run

codecov-commenter commented 10 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (1d667c7) 93.99% compared to head (74c9b03) 94.01%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #1056 +/- ## ========================================== + Coverage 93.99% 94.01% +0.01% ========================================== Files 145 145 Lines 8928 8936 +8 Branches 1142 1144 +2 ========================================== + Hits 8392 8401 +9 + Misses 320 319 -1 Partials 216 216 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

albestro commented 10 months ago

cscs-ci run

albestro commented 10 months ago

cscs-ci run

eth-cscs / DLA-Future

Fix empty case for `copy` #1056

Codecov Report