search

eth-cscs / DLA-Future

DLA-Future
https://eth-cscs.github.io/DLA-Future/master/
BSD 3-Clause "New" or "Revised" License
64 stars 14 forks source link

Workarounds for broken complex type operator overloads in HIP 5.7 onwards #1083

Closed msimberg closed 2 weeks ago

msimberg commented 9 months ago

Nothing to see here yet. This is an ugly, hacky attempt at not using the broken upstream operators, but I'm unsure if 1. it works correctly, 2. it generates the same/similar code, and 3. if it's maintainable. Opening as PR to see how it works in CI. I know it compiles with HIP 5.2.3, nothing more.

msimberg commented 9 months ago

cscs-ci run

msimberg commented 9 months ago

cscs-ci run

msimberg commented 9 months ago

cscs-ci run

msimberg commented 9 months ago

cscs-ci run

msimberg commented 8 months ago

I've just discovered that it seems like spack patches the issue in HIP: https://github.com/spack/spack/blob/develop/var/spack/repos/builtin/packages/hip/0015-reverting-operator-mixup-fix-for-slate.patch. The upstream comment about use of the operators being discouraged still applies of course, and they haven't reverted the change that broke things upstream. That said I'm probably going to lower the priority of this a bit, and we can perhaps think longer term about a "whipblas" interface.

msimberg commented 2 weeks ago

I'll close this as #1195 proposes a simpler fix. We can always revisit the more complicated approach.