eth-cscs / DLA-Future

DLA-Future
https://eth-cscs.github.io/DLA-Future/master/
BSD 3-Clause "New" or "Revised" License
64 stars 14 forks source link

Fix use of MPI GPU RDMA variables #1088

Closed msimberg closed 8 months ago

msimberg commented 8 months ago

The variables were inconsistently named, leading to the CMake variable not working. I've also made the CMake variable dependent on DLAF_WITH_HIP. At this point I've simply made them consistent, but I'd also like to propose a rename of the variable since it applies to both HIP and CUDA.

Some options:

I think I quite like the first option as it's quite straightforward to understand and uses generic enough terms (e.g. I just learned that GPUDirect seems to be an NVIDIA marketing term: https://developer.nvidia.com/gpudirect).

RMeli commented 8 months ago

+1 for DLAF_WITH_MPI_GPU_SUPPORT

msimberg commented 8 months ago

cscs-ci run

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (ea4521d) 94.05% compared to head (9a872ee) 94.04%. Report is 10 commits behind head on master.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1088 +/- ## ========================================== - Coverage 94.05% 94.04% -0.02% ========================================== Files 148 148 Lines 9204 9204 Branches 1165 1165 ========================================== - Hits 8657 8656 -1 Misses 325 325 - Partials 222 223 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.