search

eth-cscs / DLA-Future

DLA-Future
https://eth-cscs.github.io/DLA-Future/master/
BSD 3-Clause "New" or "Revised" License
64 stars 14 forks source link

Update trmm and rocBLAS status code handling to use rocBLAS 3 functionality #1091

Closed msimberg closed 8 months ago

msimberg commented 8 months ago

Uses the out-of-place rocblas_trmm whenever available. Defines ROCBLAS_V3 to make the new version of the function available. Still uses the old rocblas_trmm_outofplace for older versions. I've only tested compilation on clariden; running still seems to be problematic.

Also adds a few rocblas_status enumerations that were added in rocBLAS 3.1.0 (ROCm 5.7.0 onwards). I've also updated the rocSOLVER getErrorString function to simply forward to the rocBLAS getErrorString as they should do exactly the same (and were out-of-sync with each other).

msimberg commented 8 months ago

cscs-ci run

msimberg commented 8 months ago

The test failure is a hang in the hermitian multiplication test again (same as https://github.com/eth-cscs/DLA-Future/issues/603#issuecomment-1851956301, so not adding it again). I've restarted the job.

msimberg commented 8 months ago

cscs-ci run

codecov-commenter commented 8 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (0480b65) 94.06% compared to head (e275d58) 94.06%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #1091 +/- ## ======================================= Coverage 94.06% 94.06% ======================================= Files 148 148 Lines 9206 9206 Branches 1166 1166 ======================================= Hits 8660 8660 Misses 324 324 Partials 222 222 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

msimberg commented 8 months ago

There's definitely something funky going on with HEMM: https://gitlab.com/cscs-ci/ci-testing/webhook-ci/mirrors/4700071344751697/7514005670787789/-/jobs/6128997608#L2341. Already reported on #603, but it might be worth bumping that up the priority list. I'll see if I can reproduce it myself in the next few weeks.

rasolca commented 8 months ago

cscs-ci run