Update and export project version in CMake

eth-cscs / DLA-Future

DLA-Future

https://eth-cscs.github.io/DLA-Future/master/

BSD 3-Clause "New" or "Revised" License

64 stars 14 forks source link

Update and export project version in CMake #1121

Closed RMeli closed 5 months ago

RMeli commented 6 months ago

Currently, trying to use

find_package(DLAF 0.4.0 REQUIRED)

results in the following error:

CMake Error at CMakeLists.txt:32 (find_package):
  Could not find a configuration file for package "DLAF" that is compatible
  with requested version "0.4.0".

  The following configuration files were considered but not accepted:

    /home/rmeli/spack/opt/spack/linux-ubuntu23.10-zen4/gcc-11.4.0/dla-future-0.4.0-coebvqe54dvcjliwldugouxjxo7vv6jv/lib/cmake/DLAF/DLAFConfig.cmake, version: unknown

RMeli commented 6 months ago

cscs-ci run

msimberg commented 6 months ago

As already noted by @RMeli (https://github.com/eth-cscs/DLA-Future-Fortran/pull/1#discussion_r1568725257) the next question is if we want to patch this in spack or not. An alternative would be to release 0.4.1 with this change only. I'm mostly indifferent to which option to choose. We can also do both.

RMeli commented 6 months ago

Since we are still on 0.x, I like the idea of releasing 0.4.1. It would be the cleanest solution IMO, as we can probably avoid start adding quite a bit of patches to the Spack package.