search

eth-cscs / DLA-Future

DLA-Future
https://eth-cscs.github.io/DLA-Future/master/
BSD 3-Clause "New" or "Revised" License
61 stars 13 forks source link

Add missing includes with the help of inshpect #1129

Closed gulivarese closed 3 months ago

gulivarese commented 4 months ago

cscs-ci run

gulivarese commented 4 months ago

@msimberg I've just finished with the review about theinclude file

gulivarese commented 3 months ago

cscs-ci run

msimberg commented 3 months ago

Reminder, we should make the inshpect check required before merging this.

msimberg commented 3 months ago

Is it normal that the check takes so long? Currently 1h30 and still running.

Certainly not... It should take a couple of minutes at most. I can't seem to cancel the runs either (and check_format also seems to be stuck...). We may have to wait for the jobs to time out (hopefully) and retry. Looks like it may perhaps be an issue with the runners.

rasolca commented 3 months ago

Is it normal that the check takes so long? Currently 1h30 and still running.

Certainly not... It should take a couple of minutes at most. I can't seem to cancel the runs either (and check_format also seems to be stuck...). We may have to wait for the jobs to time out (hopefully) and retry. Looks like it may perhaps be an issue with the runners.

Apparently something is wrong with actions... even #1146 is having problems.

rasolca commented 3 months ago

cscs-ci run