eth-cscs / DLA-Future

DLA-Future
https://eth-cscs.github.io/DLA-Future/master/
BSD 3-Clause "New" or "Revised" License
64 stars 14 forks source link

TridiagSolver (dist): STEP1 rank-independent sort of eigenvalues by column type for rank1 solver #967

Closed albestro closed 10 months ago

albestro commented 1 year ago

This is a starting point towards getting a gemm cost reduction as we did for the local variant of the algorithm. Unfortunately, it will require more work than the local one, so this is just the very first step of the entire work that will come.

Note: A stablePartition function has been dropped and one has been added, resulting in a difficult to read diff (sorry for that, after merge-squashing I don't have a way to isolate it and make it easier for your review). In addition to that, I took also the chance to actually update the test with the new functionalities of the new stablePartition implementation.

albestro commented 10 months ago

cscs-ci run

albestro commented 10 months ago

cscs-ci run

codecov-commenter commented 10 months ago

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (e311f6a) 94.04% compared to head (0d16047) 94.05%.

Files Patch % Lines
include/dlaf/permutations/general/impl.h 93.93% 1 Missing and 1 partial :warning:
include/dlaf/eigensolver/tridiag_solver/merge.h 98.30% 1 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #967 +/- ## ======================================= Coverage 94.04% 94.05% ======================================= Files 145 145 Lines 9008 9068 +60 Branches 1156 1160 +4 ======================================= + Hits 8472 8529 +57 - Misses 319 321 +2 - Partials 217 218 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.