eth-cscs / DLA-Future

DLA-Future
https://eth-cscs.github.io/DLA-Future/master/
BSD 3-Clause "New" or "Revised" License
64 stars 14 forks source link

Refactor distribution and extend tests for sub-distributions #976

Closed rasolca closed 1 year ago

rasolca commented 1 year ago

This PR consists of

rasolca commented 1 year ago

It's a bit hard to follow the changes because of the renamings, but from what I can tell it looks all valid. Thanks for spotting these issues!

I only have a few higher level comments at this point.

Sorry, the first review was only meant to check if the new interface made sense.

rasolca commented 1 year ago

cscs-ci run

rasolca commented 1 year ago

cscs-ci run

rasolca commented 1 year ago

cscs-ci run

rasolca commented 1 year ago

cscs-ci run

rasolca commented 1 year ago

cscs-ci run

rasolca commented 1 year ago

cscs-ci run

codecov-commenter commented 1 year ago

Codecov Report

Merging #976 (bcb580a) into master (52704e9) will increase coverage by 0.16%. Report is 28 commits behind head on master. The diff coverage is 94.18%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

@@            Coverage Diff             @@
##           master     #976      +/-   ##
==========================================
+ Coverage   93.42%   93.59%   +0.16%     
==========================================
  Files         143      144       +1     
  Lines        8686     8852     +166     
  Branches     1118     1119       +1     
==========================================
+ Hits         8115     8285     +170     
+ Misses        383      374       -9     
- Partials      188      193       +5     
Files Coverage Δ
include/dlaf/matrix/layout_info.h 97.61% <100.00%> (ø)
include/dlaf/matrix/util_distribution.h 80.00% <100.00%> (-0.27%) :arrow_down:
src/matrix/distribution.cpp 98.95% <100.00%> (+3.63%) :arrow_up:
include/dlaf/matrix/distribution.h 93.26% <95.05%> (+4.64%) :arrow_up:
include/dlaf/matrix/distribution_extensions.h 88.88% <88.88%> (ø)

... and 6 files with indirect coverage changes

rasolca commented 1 year ago

cscs-ci run

rasolca commented 1 year ago

cscs-ci run

rasolca commented 1 year ago

cscs-ci run