This pull-request adds the following changes to the cholesky branch:
Removes the Benchmark class from the library. This was done as this object was prone to errors and often lead to segfaults and other unexpected behaviour when executing with new parameters, etc. Moreover, there is no real use for measuring the time of all ranks individually, when we then report the maximum anyway.
The cholesky_scalapack example was removed from this repository as it does not logically belong to this repository and we can benchmark MKL with Marko's repository.
Changes to the repository structure that reflect the changes in the benchmark set-up. A lot of subfolders are not necessary anymore, and older files in it were also deleted.
Refactoring of the cholesky_miniapp. It now uses cxxopts to easily parse arguments, and will now measure time with std::chrono::high_resolution_clock instead of MPI_Wtime. The run-times are dumped to the standard out or to a file that the user can specify.
Changes to the python scripts and the format of params.ini to generate launch files for the newly refactored cholesky_miniapp.
Executive Summary
This pull-request adds the following changes to the
choleskybranch:Benchmarkclass from the library. This was done as this object was prone to errors and often lead to segfaults and other unexpected behaviour when executing with new parameters, etc. Moreover, there is no real use for measuring the time of all ranks individually, when we then report the maximum anyway.cholesky_scalapackexample was removed from this repository as it does not logically belong to this repository and we can benchmark MKL with Marko's repository.cholesky_miniapp. It now usescxxoptsto easily parse arguments, and will now measure time withstd::chrono::high_resolution_clockinstead ofMPI_Wtime. The run-times are dumped to the standard out or to a file that the user can specify.params.inito generate launch files for the newly refactoredcholesky_miniapp.