Write back out of main loop

eth-cscs / conflux

Distributed Communication-Optimal LU-factorization Algorithm

BSD 3-Clause "New" or "Revised" License

12 stars 3 forks source link

Write back out of main loop #15

Closed alexnick83 closed 3 years ago

alexnick83 commented 3 years ago

Moves the write-back of the results out of the main loop.

kabicm commented 3 years ago

Can this be merged?

I added the support for row-major ordering within local blocks to COSTA: https://github.com/eth-cscs/COSTA/pull/4. We need this for conflux, because each local block in conflux is row-major and in scalapack it's col-major. Will probably finalize the PR during the day and then we are fully ready to have a proper testing and benchmarking in conflux.

alexnick83 commented 3 years ago

I merged master again. It passes the following tests:

-n 8 -M 16 -N 16 -b 2
-n 8 -M 32 -N 32 -b 2
-n 8 -M 32 -N 32 -b 4
-n 27 -M 27 -N 27 -b 3

It looks OK to me

kabicm commented 3 years ago

Since this has been solved in the master branch, and the fully-distributed testing is done in https://github.com/eth-cscs/conflux/pull/20 , we can close this PR.