search

eth-cscs / pyfirecrest

Python wrappers for the FirecREST API
https://pyfirecrest.readthedocs.io
BSD 3-Clause "New" or "Revised" License
10 stars 7 forks source link

Feedback from aiida-firecrest #61

Open chrisjsewell opened 1 year ago

chrisjsewell commented 1 year ago

Heya @ekouts just before I forget, as we just discussed, https://github.com/aiidateam/aiida-firecrest is now provisionally working with the latest version of pyfirecrest thanks 🎉

Feel free to have a look and provide any feedback. A few notes (that I may add to later):

  1. I am using an improved version of #43 here: https://github.com/aiidateam/aiida-firecrest/blob/main/aiida_firecrest/remote_path.py, maybe this can eventually be upstreamed to here
  2. I'm running the tests against a live instance of the firecrest demo server in Github CI: https://github.com/aiidateam/aiida-firecrest/blob/eb7f7518857794a99bae3568c74f0981b695dd79/.github/workflows/server-tests.yml
  3. https://github.com/eth-cscs/firecrest/issues/191 is currently the major block for production
  4. The next major improvement is to look into improving large file transfers: https://github.com/aiidateam/aiida-firecrest/issues/23
ekouts commented 1 year ago

Thanks a lot @chrisjsewell , your feedback is always useful!

(1) and (3): For the next weeks, we will prioritize https://github.com/eth-cscs/firecrest/issues/191 and #43 . (2) And running the tests against the demo server would be much easier than what I am currently doing so I will have a look. (4) These are changes in the AiiDa side, correct?

chrisjsewell commented 1 year ago

These are changes in the AiiDa side, correct?

yep indeed, although there may eventually be something to upstream