Unique name for auth file - Githubissues

eth-cscs / sarus

OCI-compatible engine to deploy Linux containers on HPC environments.

https://sarus.readthedocs.io/en/stable/

BSD 3-Clause "New" or "Revised" License

130 stars 10 forks source link

Unique name for auth file #31

Closed finkandreas closed 1 year ago

finkandreas commented 1 year ago

This should fix #30

Madeeks commented 1 year ago

Thanks for opening this! A few kind requests and suggestions:

Could you please rebase this branch on develop and also target the PR to develop?
Would you be willing to update the unit tests regarding the auth file?
The utility function makeUniquePathWithRandomSuffix() is a more fitting choice for this fix, and internally calls generateRandomString() which you already used in the commit.
I believe this deserves a mention as a Fixed item in the changelog. I can take care of that if you prefer.

finkandreas commented 1 year ago

I have changed the base to develop
adapted the unit tests
- The first check for non-existent auth.json seems a little bit unnecessary, but I left it there
I did not spot the functio nmakeUniquePathWithRandomSuffix(), but you are absolutely right, it is the better choice
I added a changelog item, feel free to change the wording there