search

eth-cscs / stackinator

https://eth-cscs.github.io/stackinator/
BSD 3-Clause "New" or "Revised" License
19 stars 15 forks source link

Mirror as positional argument #119

Closed RMeli closed 1 year ago

RMeli commented 1 year ago

Fix #115

bcumming commented 1 year ago

Has this been tested with v0.19 of Spack? We try to maintain support for the last two releases of Spack (which corresponds roughly to the last 6-12 months of releases). In this case we should still make the change to support develop, but it would be good to know if we have to disable support for v0.19 early.

bcumming commented 1 year ago

This breaks with v0.19.

spack -e ./bootstrap buildcache create --rebuild-index --allow-root --only=package alpscache \
$(spack --color=never -e ./bootstrap find --format '{name};{/hash}' | grep -v -E '^();' | cut -d ';' -f2)
usage: spack buildcache create [-hrfua] [-k key]
                               (-d directory | -m mirror-name | --mirror-url mirror-url)
                               [--rebuild-index] [--spec-file SPEC_FILE]
                               [--only {package,dependencies}]
                               ...
spack buildcache create: error: one of the arguments -d/--directory -m/--mirror-name --mirror-url is required

We could deprecate support for 0.19, which is a bit annoying to do because such a short gap between deprecation and removal for a flag change isnt' justified.

Alternatively, we could add a --develop flag, that optionally implements work arounds for issues in the develop branch, that can be merged when a new release of Spack is made.

toxa81 commented 1 year ago

I vote for --develop flag. This is not the last issue of such kind.

RMeli commented 1 year ago

Closing because formatting is no longer up-to-date and I can't be bothered to partially revert the changes (I mixed the feature and formatting in a single commit, unfortunately). I'll open a new PR implementing the --develop option.