search

eth-easl / modyn

Modyn is a research-platform for training ML models on growing datasets.
MIT License
29 stars 3 forks source link

Inform selector of label #110

Closed K-Shao closed 1 year ago

K-Shao commented 1 year ago

For GDumb strategy, the selector needs to be informed of the data's label along with the key and timestamp.

MaxiBoether commented 1 year ago

Ah, you mean that the Supervisor informs the Selector not only about the key of the new data, but also the label? That should definitely be easily possible when plumbing together, since #81 already solved the label transfer from storage to supervisor, so we will just need to forward it :)

MaxiBoether commented 1 year ago

(For now, just expect the Selector to receive everything that it needs, i.e., the protos gRPC request for informing expects a label. We can do a follow-up PR plumbing everything together)

K-Shao commented 1 year ago

Yes I don't imagine it'll be very hard. However I just wanted an issue to track it. It's also not essential for the Hello World training since the DataFreshnessSelector does not use the labels.

MaxiBoether commented 1 year ago

Sure! I just wanted to make sure that you don't have to solve the entire plumbing in the next PR, but just build the Selector with what it needs (such as labels), and then we can change the current no-op inform functionality in the supervisor in the way we need it to be.