search

eth-easl / modyn

Modyn is a research-platform for training ML models on growing datasets.
MIT License
22 stars 3 forks source link

feat: Add `codecov` #502

Closed robinholzi closed 1 month ago

robinholzi commented 1 month ago

Motivation

Let's integrate codecov to get rid of the bulky coverage messages

robinholzi commented 1 month ago

@MaxiBoether Can you get a CODECOV_TOKEN from https://app.codecov.io/gh/eth-easl/modyn/settings and store it as a repository secret?

github-actions[bot] commented 1 month ago

Line Coverage: -% ( % to main) Branch Coverage: -% ( % to main)

MaxiBoether commented 1 month ago

@MaxiBoether Can you get a CODECOV_TOKEN from https://app.codecov.io/gh/eth-easl/modyn/settings and store it as a repository secret?

Will do tomorrow! Thank you!!

MaxiBoether commented 1 month ago

@MaxiBoether Can you get a CODECOV_TOKEN from https://app.codecov.io/gh/eth-easl/modyn/settings and store it as a repository secret?

Will do tomorrow! Thank you!!

Done

codecov[bot] commented 1 month ago

Welcome to Codecov :tada:

Once you merge this PR into your default branch, you're all set! Codecov will compare coverage reports and display results in all future pull requests.

Thanks for integrating Codecov - We've got you covered :open_umbrella:

robinholzi commented 1 month ago

Nice @MaxiBoether , maybe you can generate a badge and add it to the README, then we are ready to merge :)

MaxiBoether commented 1 month ago

Just fyi, we actually also have C++ coverage, but something there is broken and I never found the time to investigate this. In any case, not that important...

robinholzi commented 1 month ago

Just fyi, we actually also have C++ coverage, but something there is broken and I never found the time to investigate this. In any case, not that important...

Unfortunately, I'm not extremely proficient with cpp tooling, and currently don't have the time to dive into that😅