Closed XianzheMa closed 1 month ago
Attention: Patch coverage is 50.00000%
with 4 lines
in your changes missing coverage. Please review.
Project coverage is 82.18%. Comparing base (
6d621ad
) to head (6c0e9c2
).
Files | Patch % | Lines |
---|---|---|
.../internal/pipeline_executor/evaluation_executor.py | 33.33% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
( % to main)
( % to main)
I need to resolve the comment to merge the PR, so I copy-paste my question here: We somehow don't have a unit test file for the quite large evaluation_executor.py. https://github.com/eth-easl/modyn/pull/490
@robinholzi Is there a reason? If the missing unit test is not intentional please add one!
I will for the moment also make patch action informational. As it does not make sense for me to create a huge unit test only to cover these trivial changes.
@XianzheMa I guess that depends on what you define as a unit
. We are testing the logic in evaluation_executor
with the logic from test_pipeline_supervisor
just like we did before the introduction of evaluation_executor
. As there are some uncovered parts though, I will add dedicated tests for them! Thanks for the pointer!
Per the title, this solves https://github.com/eth-easl/modyn/issues/508.