eth-easl / modyn

Modyn is a research-platform for training ML models on growing datasets.
MIT License
22 stars 3 forks source link

Fix unsynced warmup across selector instances #512

Closed XianzheMa closed 1 month ago

XianzheMa commented 1 month ago

This PR acts more as a patch rather than a fundamental fix to the asynchronism across different selector instances.

A fundamental fix should make the selection strategy stateless: by getting rid of the fieldself._next_trigger_id and providing it in the upstream as an argument.

This PR reduces the statefullness by removing the self.is_warmup.

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 40.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 82.14%. Comparing base (5ad108a) to head (b768242).

Files Patch % Lines
...r/internal/selector_strategies/coreset_strategy.py 50.00% 4 Missing :warning:
modyn/selector/selector.py 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #512 +/- ## ========================================== - Coverage 82.18% 82.14% -0.04% ========================================== Files 214 214 Lines 9961 9962 +1 ========================================== - Hits 8186 8183 -3 - Misses 1775 1779 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

Line Coverage: -% ( % to main) Branch Coverage: -% ( % to main)