Closed XianzheMa closed 1 month ago
Attention: Patch coverage is 40.00000%
with 6 lines
in your changes missing coverage. Please review.
Project coverage is 82.14%. Comparing base (
5ad108a
) to head (b768242
).
Files | Patch % | Lines |
---|---|---|
...r/internal/selector_strategies/coreset_strategy.py | 50.00% | 4 Missing :warning: |
modyn/selector/selector.py | 0.00% | 2 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
( % to main)
( % to main)
This PR acts more as a patch rather than a fundamental fix to the asynchronism across different selector instances.
A fundamental fix should make the selection strategy stateless: by getting rid of the field
self._next_trigger_id
and providing it in the upstream as an argument.This PR reduces the statefullness by removing the
self.is_warmup
.