eth-easl / modyn

Modyn is a research-platform for training ML models on dynamic datasets.
MIT License
22 stars 3 forks source link

Multithreaded error handling in storage #524

Closed MaxiBoether closed 2 weeks ago

MaxiBoether commented 2 weeks ago

If a thread in the get implementation throws an error, the storage currently dies because C++ does not propagate exceptions to the caller. With this change, we're able to return a gRPC error instead. Also, we throw now in case the file path is empty.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.50%. Comparing base (0a511bb) to head (e07f0ab).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #524 +/- ## ========================================== + Coverage 82.43% 82.50% +0.06% ========================================== Files 214 214 Lines 10039 10039 ========================================== + Hits 8276 8283 +7 + Misses 1763 1756 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Line Coverage: -% ( % to main) Branch Coverage: -% ( % to main)