eth-easl / modyn

Modyn is a research-platform for training ML models on dynamic datasets.
MIT License
22 stars 3 forks source link

Fail explicitly in storage when asking for duplicate keys #530

Closed MaxiBoether closed 2 weeks ago

MaxiBoether commented 2 weeks ago

When debugging #529 I realized this is a silent problem (we might access memory of a vector that is not allocated), so we should just explicitly fail.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 82.43%. Comparing base (c52a3d6) to head (e801778). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #530 +/- ## ======================================= Coverage 82.43% 82.43% ======================================= Files 214 214 Lines 10039 10039 ======================================= Hits 8276 8276 Misses 1763 1763 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Line Coverage: -% ( % to main) Branch Coverage: -% ( % to main)