search

eth-easl / modyn

Modyn is a research-platform for training ML models on dynamic datasets.
MIT License
22 stars 3 forks source link

Fix unfixed naming inconsistencies #531

Closed XianzheMa closed 2 weeks ago

XianzheMa commented 2 weeks ago

It turns out my last PR didn't rename all the variables completely, thereby causing CI failures. This PR fixes it.

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.71429% with 1 line in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (84dac1d) to head (4655326). Report is 2 commits behind head on main.

Files Patch % Lines
...trainer_server/internal/trainer/pytorch_trainer.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #531 +/- ## ========================================== + Coverage 82.44% 82.49% +0.04% ========================================== Files 214 215 +1 Lines 10042 10053 +11 ========================================== + Hits 8279 8293 +14 + Misses 1763 1760 -3 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

Line Coverage: -% ( % to main) Branch Coverage: -% ( % to main)

robinholzi commented 2 weeks ago

what a PR title xD