Integration tests - Githubissues

eth-easl / modyn

Modyn is a research-platform for training ML models on growing datasets.

MIT License

25 stars 3 forks source link

Integration tests #54

Open MaxiBoether opened 1 year ago

MaxiBoether commented 1 year ago

We want to have integration tests for the following components:

[x] Availability of all services after docker-compose up
[x] Storage (Fixed with #112)
[ ] Training Server
[ ] Selector
[ ] Supervisor (probably in form of an example pipeline, as the supervisor itself does not offer an gRPC service)
[x] Metadata Processor

vGsteiger commented 1 year ago

I will implement the storage integration test in the coming week(s).

MaxiBoether commented 1 year ago

If you want to, feel free, otherwise I can also tackle this. What I wanted to do is the following test:

Connect to the Storage gRPC service.
Create a new dataset
Post an image to that dataset
Get informed about new data and ensure that the image is actually in the answer
Get the image and confirm that the bytes are equal to the image that we posted to the dataset

A second test could post multiple images and ensure that the "inform about new data" functionality works correctly.

vGsteiger commented 1 year ago

I would like to tackle this in this week as I don't really want to touch the Metadata database for now. I will start on that as soon as Kevin is through but I want to save myself the hustle of having to cherrypick and rebase later.

MaxiBoether commented 1 year ago

Ok, sounds good. Otherwise, you could also jump in in Kevin's PR and maybe together with him push that PR so we can merge (I think if two people sit down for 2-3 hours in a live share session and go through all review comments, that PR can be merged).

vGsteiger commented 1 year ago

I assigned myself that I see which issues are open for me.