search

eth-easl / modyn

Modyn is a research-platform for training ML models on dynamic datasets.
MIT License
22 stars 3 forks source link

feat: Refine triggering abstraction #546

Closed robinholzi closed 2 weeks ago

robinholzi commented 2 weeks ago

Motivation

Let's refine the abstraction for trigger a bit to enable more powerful triggering configuration.

Changes

Note: we will adjust the business logic in the future to use the new abstraction.

github-actions[bot] commented 2 weeks ago

Line Coverage: -% ( % to main) Branch Coverage: -% ( % to main)

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 93.84615% with 4 lines in your changes missing coverage. Please review.

Project coverage is 82.83%. Comparing base (42354cf) to head (1a01977). Report is 3 commits behind head on main.

Files Patch % Lines
modyn/config/schema/pipeline/trigger/ensemble.py 87.09% 4 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #546 +/- ## ========================================== + Coverage 82.81% 82.83% +0.02% ========================================== Files 217 220 +3 Lines 10152 10196 +44 ========================================== + Hits 8407 8446 +39 - Misses 1745 1750 +5 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.