eth-easl / modyn

Modyn is a research-platform for training ML models on dynamic datasets.
MIT License
22 stars 3 forks source link

feat: Create `DriftDetector` abstraction and introduce alibi-detect #551

Closed robinholzi closed 5 days ago

robinholzi commented 1 week ago

Motivation

We want to be able to use both evidently and alibi-detect as they support different drift detection metrics as well as differ in their runtime performance.

For that we need a clean abstraction that allows us to delegate drift detection to the respective library

Changes

Note:

As this is rather big already, I'd like to get this merged before trying to run drift detection pipelines, so we might need slight adjustments in a followup PR.

github-actions[bot] commented 1 week ago

Line Coverage: -% ( % to main) Branch Coverage: -% ( % to main)

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 82.81250% with 55 lines in your changes missing coverage. Please review.

Project coverage is 83.01%. Comparing base (b1b71c2) to head (4dac260). Report is 4 commits behind head on main.

Files Patch % Lines
...n/supervisor/internal/triggers/datadrifttrigger.py 42.10% 22 Missing :warning:
.../supervisor/internal/triggers/drift/metrics/mmd.py 71.42% 16 Missing :warning:
...pervisor/internal/triggers/drift/modyn_detector.py 60.86% 9 Missing :warning:
...onfig/schema/pipeline/trigger/drift/aggregation.py 87.50% 2 Missing :warning:
...pervisor/internal/triggers/drift/alibi_detector.py 95.00% 2 Missing :warning:
...pervisor/internal/triggers/drift/drift_detector.py 84.61% 2 Missing :warning:
...isor/internal/triggers/drift/evidently_detector.py 95.12% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #551 +/- ## ========================================== + Coverage 82.84% 83.01% +0.17% ========================================== Files 220 231 +11 Lines 10202 10505 +303 ========================================== + Hits 8452 8721 +269 - Misses 1750 1784 +34 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

robinholzi commented 5 days ago

superseded by https://github.com/eth-easl/modyn/pull/555