search

eth-educators / eth-docker

Docker automation for Ethereum nodes
Apache License 2.0
471 stars 220 forks source link

Can a flag be added to ethd restart command? #1078

Closed Mercury196 closed 1 year ago

Mercury196 commented 1 year ago

Recommend a flag option to ethd restart command for a single override of .env parameter. Currently, I edit the .env file before and after I run ethd restart to set doppelganger=false for one instance. I keep .env set to doppelganger=true but for an intentional restart, I will disable doppelganger one time.

yorickdowne commented 1 year ago

Doppelganger really is only meant to be used for moving keys. Restarts don't require it, as you are in the same instance of the validator client and the validator client has a slashing protection DB inside persistent storage, its docker volume.

Unless you have reason to believe your keys may become active in another instance of the validator client, with different storage, there's no need to use doppelganger.

Mercury196 commented 1 year ago

Hi Yorick. Thank you for the response. I agree doppelganger is 99.999...% not needed for restart. I keep it enabled for any uncommanded restart to handle the very rare (but possible) bug, hardware failure, db corruption, power outtage combination where having it enabled "might" help mitigate a problem. Risk/reward for me says to keep it enabled. Maybe it's just peace of mind. Anyhow, I edit .env before and after every update and restart for this reason.

Cheers and happy holidays!!

On Fri, Nov 25, 2022, 8:06 AM yorickdowne @.***> wrote:

Closed #1078 https://github.com/eth-educators/eth-docker/issues/1078 as completed.

— Reply to this email directly, view it on GitHub https://github.com/eth-educators/eth-docker/issues/1078#event-7893455002, or unsubscribe https://github.com/notifications/unsubscribe-auth/A4GVSXQAEFULLJLLYWC4L3DWKDBV5ANCNFSM6AAAAAASLKPZ6U . You are receiving this because you authored the thread.Message ID: @.***>