search

eth-educators / ethstaker-deposit-cli

Secure key generation for deposits
https://eth-educators.github.io/ethstaker-deposit-cli/
Creative Commons Zero v1.0 Universal
4 stars 7 forks source link

Add prompt for withdrawal address #16

Closed valefar-on-discord closed 6 months ago

valefar-on-discord commented 6 months ago

The CLI has an optional parameter --execution_address or --eth1_withdrawal_address. The problem is there is no prompt for this value.

Utilizing logic similar to this should be easy enough: https://github.com/eth-educators/ethstaker-deposit-cli/blob/main/staking_deposit/cli/generate_bls_to_execution_change.py#L111

Unit tests will need to be updated to include this change.

remyroy commented 6 months ago

The default should be to prompt for a withdrawal address and it should be emphazised that a withdrawal address is strongly recommended.

remyroy commented 6 months ago

This is completed with #27.