search

eth-educators / ethstaker-deposit-cli

Secure key generation for deposits
https://eth-educators.github.io/ethstaker-deposit-cli/
Creative Commons Zero v1.0 Universal
3 stars 5 forks source link

Improve wording of verification messages #41

Closed valefar-on-discord closed 1 month ago

valefar-on-discord commented 5 months ago

Forwarded from:

There is a concern around the wording that is used when verifying deposits that could lead the user to think the deposit is being made at that moment.

The suggested fix is to change the wording to specify it involves verifying the file.

sakshitposting-irl commented 5 months ago

Hey @valefar-on-discord I wish to get on this issue, can you let me know more about this?

valefar-on-discord commented 5 months ago

Hey @valefar-on-discord I wish to get on this issue, can you let me know more about this?

When you generate keys, whether through new-mnemonic or existing-mnemonic, you are presented with output as you go through the creation and verification. The concern is around the wording of the output saying Verifying your deposits which could be misinterpreted to mean that the deposit was executed.

The suggestion in the linked issue is to update the wording to specify that the cli is creating and verified files.