eth-educators / ethstaker-deposit-cli

Secure key generation for deposits
https://eth-educators.github.io/ethstaker-deposit-cli/
Creative Commons Zero v1.0 Universal
2 stars 2 forks source link

Coroutine raised StopIteration ci-runner error #62

Open valefar-on-discord opened 1 month ago

valefar-on-discord commented 1 month ago

After landed #48 I noticed the ci-runner failed with a non-assertion error but a RuntimeError: coroutine raised StopIteration https://github.com/valefar-on-discord/ethstaker-deposit-cli/actions/runs/9331869782/job/25687038382

I tried to reproduce this locally to no avail and I haven't seen it since from git actions but something to keep a look out for

valefar-on-discord commented 1 month ago

Saw the exact failure again: https://github.com/valefar-on-discord/ethstaker-deposit-cli/actions/runs/9438041063/job/25994595794

remyroy commented 1 month ago

I believe I just reproduced this issue on https://github.com/remyroy/ethstaker-deposit-cli/actions/runs/9451804698/job/26033609500

remyroy commented 4 weeks ago

This seems to be related to the use of pipes in asyncio.create_subprocess_shell. The only tests failing are those that uses pipes (only 2, test_script_abbreviated_mnemonic and test_script_bls_withdrawal in tests/test_cli/test_new_mnemonic.py)