search

eth-educators / ethstaker-deposit-cli

Secure key generation for deposits
https://eth-educators.github.io/ethstaker-deposit-cli/
Creative Commons Zero v1.0 Universal
2 stars 2 forks source link

Replace custom test directory setup and clean up with the tempfile features #66

Closed remyroy closed 4 weeks ago

remyroy commented 4 weeks ago

This should help fix #62 .

remyroy commented 4 weeks ago

The Github diff is harder to read than necessary but the gist of this PR is to remove all the custom test directory setup and clean up in tests and replace it with the TemporaryDirectory from the tempfile module. It uses the context manager for automatic clean up. It helps prevent the races on macOS by using a different temporary directory each time.

remyroy commented 4 weeks ago

It seems like there is still some unexpected issues on macOS 12 and Python 3.9 on https://github.com/remyroy/ethstaker-deposit-cli/actions/runs/9484868682/job/26135419117