search

eth-igl / gp2024-Assignments

0 stars 0 forks source link

[Assignment 5] libigl version 2.5.0 and `set_initial_mesh` #39

Open DJAntivenom opened 4 months ago

DJAntivenom commented 4 months ago

Hi there

I have two questions:

  1. Are we allowed to change the CMakeLists.txt to use libigl version 2.5.0 instead of 2.4.0? This would give us access to Eigen 3.4.0 which has helpful modern c++ features.
  2. Are we allowed to change the implementation of Deformation::set_initial_mesh(...) if we don't change the signature?

Best, Dillon

PeizhuoLi commented 4 months ago

Hi Dillon,

  1. Unfortunately, you may not change the CMakeLists.txt because it is subject to automatic test and changing it may lead to compilation failure.
  2. According to the implementation guideline, as long as the signature stays the same, you are allowed to change the implementation.

Best, Peizhuo