package.json in main branch in using openzeppelin v4 which has breaking changes in openzeppelin v5

eth-infinitism / account-abstraction

GNU General Public License v3.0

1.49k stars 616 forks source link

package.json in main branch in using openzeppelin v4 which has breaking changes in openzeppelin v5 #471

Closed ANNMAINAWANGARI closed 4 months ago

ANNMAINAWANGARI commented 4 months ago

@openzeppelin/contracts/token/ERC777/IERC777Recipient.sol is not exported in openzeppelin v5 which is being used in account-abstraction/contracts/samples/callback/TokenCallbackHandler.sol. This does not work in openzeppelin v5. npm i @account-abstraction/contracts uses openzeppelin v4. Suggest upgrading in the main branch.

drortirosh commented 4 months ago

the old (v0.6) version of the package (on branch releases/v0.6) did use openzeppelin v4, but the latest version (v0.7, on branch develop and master) uses openzeppelin v5, and removed any reference to the deprecated ERC777

ANNMAINAWANGARI commented 4 months ago

How can I use v0.7,I guess one can fork but is there a way to use it via npm install @account-abstraction/contracts?

drortirosh commented 4 months ago

npm install @account-abstraction/contracts. the v0.7 is the published version.

ANNMAINAWANGARI commented 4 months ago

Great thanks