eth-protocol-fellows / protocol-studies

A study group learning about Ethereum and building protocol wiki
Other
130 stars 81 forks source link

Wiki - PBS research content #162

Closed taxmeifyoucan closed 3 months ago

taxmeifyoucan commented 3 months ago

PBS wiki

Adding multiple pages on PBS and related MEV topics.

github-actions[bot] commented 3 months ago

Hi @taxmeifyoucan,

Following typos were found in the pull request:

ℹ️ Here's how to fix them:

raxhvl commented 3 months ago

Hey @thogiti the wordlist has a space character please remove it.

image

thogiti commented 3 months ago

Hey @thogiti the wordlist has has space please remove it.

image

Yes, thank you. Updating all spell checks and wordlist for the all files in `/PBS/ folder.

I installed aspell locally and testing it locally before I push another commit.

github-actions[bot] commented 3 months ago

Hi @taxmeifyoucan,

Following typos were found in the pull request:

ℹ️ Here's how to fix them:

thogiti commented 3 months ago

@raxhvl @taxmeifyoucan Ok, now spelling errors check is passed. I ran aspell locally before pushing the commit.

I want to take a look at the content structure in the /PBS/ section and suggest some edits.

thogiti commented 3 months ago

Alot of relevant details are not readable, due to sheer length of the ePBS entry. Also the relevant parts' readability is undermined due some other parts like desirable properties, for and against arguments and other alike parts.

Can you please identify which specific parts are not readable for you?

I wrote ePBS to be a self-contained page where you can learn all the nuances about enshrining PBS.

If you follow the feedback from outside Ethereum (e.g. Flashbots group, Hasu, Jon Charbonneau, relayers, etc.), you will see two main categories of discussion and opposition to the current implementations:

  1. What is the problem a specific ePBS implementation is trying to solve?
  2. How to address "bypassability"?

So, understanding from the first principles which specific properties a minimum viable ePBS implementation should have helps addressing two above problems.

I added these references and the Ethereum Foundation's ePBS rollcalls/breakout meetings in my document fully grasp the nuances of enshrining PBS mechanism.

shyam-patel-kira commented 3 months ago

Alot of relevant details are not readable, due to sheer length of the ePBS entry. Also the relevant parts' readability is undermined due some other parts like desirable properties, for and against arguments and other alike parts.

Can you please identify which specific parts are not readable for you?

I wrote ePBS to be a self-contained page where you can learn all the nuances about enshrining PBS.

The content is definitely well researched, and I think this PR should be merged since it has been open for too long anyway, but some points to consider, maybe us or someone else can curate it in future PR:

What do you think @thogiti? but I agree that this can be potentially done in future PR, this serves as a good foundation for this wiki page

thogiti commented 3 months ago

@taxmeifyoucan This PBS section is ready to be merged into main branch.

Thank you for your contributions @shyam-patel-kira @arynyestos @raxhvl @taxmeifyoucan @thogiti.

shyam-patel-kira commented 3 months ago

This should close #93

thogiti commented 3 months ago

This should close #93

Once this PR is merged, you can close the issue at #93.

github-actions[bot] commented 3 months ago

Hi @taxmeifyoucan,

Following typos were found in the pull request:

ℹ️ Here's how to fix them:

thogiti commented 3 months ago
  1. commmunication

I will push another commit to address these typos. Give me five minutes.

taxmeifyoucan commented 3 months ago

Once again, huge thanks to all of you for working on all of this! Great job guys, it's an amazing piece of content.

I read it again and added some resources, rephrased few things. I agree with points by @shyam-patel-kira above, the content could be more lean and improve readability of long section. Also, there still are more resources that could be linked, I was surprised that the builder spec was not mentioned. Maybe after Barnabes talk today you will find some more improvements. For now let's merge it and have another PR in the future, thanks a lot